fix: support Guzzle 8 - #207
Closed
kOld wants to merge 3 commits into
Closed
Conversation
Collaborator
|
Hmm this matrix is going to get insane if we have to add Guzzle to it. On top of Laravel, PHP and Pest. I can probably drop Pest to only 4/5. I'll wait till this stabilizes and brainstorm. |
Author
|
Closing this draft for now so we do not leave exploratory compatibility work open while upstream direction is unsettled. Thank you for the review. |
Collaborator
|
Yeah no worries. I appreciate the work. I will take it from wherever you end it. I just saw your earlier commits of another matrix which got me thinking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This package currently requires Guzzle ^7.9.3 even though its integration uses the PSR-compatible Guzzle client. This widens the requirement to allow Guzzle 8.
Guzzle 8 has stricter constructor configuration types, so the request timeout now uses Laravel's typed config accessor: config()->integer('openai.request_timeout', 30).
No workflow changes are needed: the existing prefer-stable matrix resolves Guzzle 8 for Laravel 13, while Laravel 11/12 and prefer-lowest remain on Guzzle 7 because of their framework constraints.
Validation
Related work
I searched the open pull requests for Guzzle-related work. PR #127 is about a PSR-18-compatible Laravel HTTP wrapper, not Guzzle 8 support, so this addresses a separate compatibility gap.