fix: respect SHELL on Windows for Git Bash#178
Merged
dkundel-openai merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Windows Git Bash compatibility when spawning Codex-related subprocesses.
On Windows, Node’s
shell: truedefaults tocmd.exe, even when the user is running from Git Bash. This updates the direct app-server spawn path and shared command runner to preferprocess.env.SHELLon Windows, falling back to the existing shell behavior whenSHELLis not set.Pulls the Git Bash shell fix from #148 while intentionally leaving out that PR’s unrelated full-access option change.
Fixes #138.
Changes
process.env.SHELL || truefor Windows shell selection inSpawnedCodexAppServerClientrunCommandshell: falseTesting
npm test