Skip to content

some implement of streaming api may return "" as finish_reason #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

some implement of streaming api may return "" as finish_reason #389

wants to merge 2 commits into from

Conversation

migeyusu
Copy link

some implement of streaming api may return "" as finish_reason such as o3 (https://o3.fan/).

@migeyusu
Copy link
Author

QQ20250325-122743
as you see , some implement will use "" as finish_reason, this works well in cherry studio, but throw exception in OpenAI:
"Unknown ChatFinishReason value."
It should be regarded as null and goto continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseharriaga joseharriaga Awaiting requested review from joseharriaga joseharriaga is a code owner

@trrwilson trrwilson Awaiting requested review from trrwilson trrwilson is a code owner

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja ShivangiReja is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@migeyusu