Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a check to handle empty or newline-only strings before calling from_json #2007

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −0
Open

fix: add a check to handle empty or newline-only strings before calling from_json #2007

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a75ff6e
fix: add a check to handle empty or newline-only strings before calli…
senorNox Jan 11, 2025
ce2c36c
style: adjust comment format for better readability
senorNox Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/openai/lib/streaming/chat/_completions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,7 @@ def _accumulate_chunk(self, chunk: ChatCompletionChunk) -> ParsedChatCompletionS
choice_snapshot.message.content
and not choice_snapshot.message.refusal
and is_given(self._rich_response_format)
and choice_snapshot.message.content.strip() # Add filter to ensure no parsing errors
senorNox marked this conversation as resolved.
Show resolved Hide resolved
senorNox marked this conversation as resolved.
Show resolved Hide resolved
):
choice_snapshot.message.parsed = from_json(
bytes(choice_snapshot.message.content, "utf-8"),
Expand Down