Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(structured outputs): avoid parsing empty empty content #2023

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

rjoshi
Copy link
Contributor

@rjoshi rjoshi commented Jan 15, 2025

Fixing #1763 where parsing often fails when content is empty string instead of None.

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Additional context & links

Fixing openai#1763 where parsing often fails when content is empty string instead of None.
@rjoshi rjoshi requested a review from a team as a code owner January 15, 2025 23:30
@RobertCraigie RobertCraigie changed the title Refactor condition to leverage truthiness for message.content in parsing fix(structured outputs): avoid parsing empty empty content Jan 16, 2025
@RobertCraigie RobertCraigie changed the base branch from main to next January 16, 2025 12:43
Copy link
Collaborator

@RobertCraigie RobertCraigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RobertCraigie RobertCraigie merged commit 6d3513c into openai:next Jan 16, 2025
2 checks passed
@stainless-app stainless-app bot mentioned this pull request Jan 16, 2025
stainless-app bot pushed a commit that referenced this pull request Jan 17, 2025
Fixing #1763 where parsing often fails when content is empty string instead of None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants