Closed
Conversation
Collaborator
|
Thanks for the PR! The internal version already uses the new PyO3 Bound API, I'll sync the codebase. |
Collaborator
|
tiktoken 0.8 ships 3.13 wheels. Needed a few things to be different from this diff. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! With python 3.13 coming out (hopefully) later today, it would be nice to have wheels for the new version available.
This PR adds Python 3.13 to the versions for which tiktoken should be built (for now together with
CIBW_PRERELEASE_PYTHONS: True, since only3.13.0rc2is available to date). It also bumpspyo3to version0.22which supports Python 3.13, together with thegil-refsfeature flag for backwards compatibility.I suppose a discussion could be had about whether support for Python 3.8 should be dropped due to its end-of-life, but that's for another day.
Let me know if there's anything else that should be accounted for, my experience with Rust is very limited :)