Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Add Python 3.13 to the testing #2487

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 4, 2025

Python 3.13 was blocked waiting on
numba>=0.61.0 -- https://pypi.org/project/numba/#history and
triton>3.1.0 -- https://pypi.org/project/triton/#history
but now the PyPI releases of both are compatible with Python 3.13.

@rdinkel
Copy link

rdinkel commented Jan 29, 2025

Hey,
what is the current state here?
triton 3.2.0 is available.
I am asking because the flatpak of kdenlive ships with python 3.13 and installing whisper inside fails building wheel.

@cclauss
Copy link
Contributor Author

cclauss commented Jan 29, 2025

@jongwook Tests on Python 3.13 now pass with the new versions of numba and triton.

@rdinkel When you think a pull request is useful and is ready to be merged, please consider giving it a positive review.

Every check mark ✔️ at the top right of this page gives project maintainers confidence that the proposed changes have been read through and deemed both useful and safe to merge into the codebase. Lots of 👍 and "what is the ETA?" comments are easier for maintainers to ignore than ✔️✔️✔️✔️✔️ from several different reviewers.

Anyone can review a pull request on GitHub. To do so here:

  1. Scroll to the top of this page.
  2. Click the Files changed tab and read through each file carefully looking for potential issues.
  3. Click the Review changes button.
  4. Click Approve (or one of the other options) and add comments only if they have not already been stated in the PR.
  5. Click Submit review so that your ✔️ will be added to the list.

Copy link

@rdinkel rdinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants