You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes#2069
This PR updates the defaultBodySerializer to correctly serialize the body if Content-Type header is set to x-www-form-urlencoded. This is useful for OAuth2 token requests.
How to Review
I'm not sure about the headers: what type are they, and are they normalized?
I added handling for both a plain JS object (headers['Accept-Content']) and a Headers object (headers.get['Accept-Content']), as well as both capitalized and lower-case versions.
Checklist
Unit tests updated
docs/ updated (if necessary)
pnpm run update:examples run (only applicable for openapi-typescript)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
So these are the headers unique to this request (probably could be named better). Below on line 92, we merge all the headers together. We should probably move that up, adn pass that in here to bodySerializer. That way it takes into account headers that users have set in their createClient() call, and it handles the normalization for you so it’s always a Header type (and you aren’t dealing with what the user passed in)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #2069
This PR updates the
defaultBodySerializerto correctly serialize the body ifContent-Typeheader is set tox-www-form-urlencoded. This is useful for OAuth2 token requests.How to Review
I'm not sure about the headers: what type are they, and are they normalized?
I added handling for both a plain JS object (
headers['Accept-Content']) and aHeadersobject (headers.get['Accept-Content']), as well as both capitalized and lower-case versions.Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)