Various issues with lightsensor.service using TSL2561

[techdev5521]

What phone do you have?

Google Pixel 5

What OS version? / What crankshaft version?

Alpha 7.4

Steps to reproduce the bug, if you're planning to report a bug. Please indicate whether the bug is always repoducible.

• Results vary according to unknown factors.
• Connect TSL2561 to Pi

TSL2561 Pin		Pi Pin
VCC	-->	Pin 1 (3.3v)
GND	-->	Pin 9 (GND)
SCL	-->	Pin 5 (SCL)
SDA	-->	Pin 3 (SDA)

• Enable light sensor in settings: Settings --> CS HW --> Lightsensor = tsl2561
• (Optional) Enable Lux output on screen: Settings --> TSL2561 --> Check 'Show Lux value....'
• Restart

Please provide any further information that you might find helpful if available.

Issues include :

• Occasional inability to detect TSL2561 device. (This could be my own connection.)
• Occasional issue with rounding Lux value resulting in non-integer value used for screen brightness:

# Relevant lines from journalctl -u lightsensor.service -b
Nov 23 18:02:35 CRANKSHAFT-NG systemd[1]: Started Crankshaft Lightsensor Service.
Nov 23 18:02:36 CRANKSHAFT-NG service_lightsensor.py[4466]: TSL2561
Nov 23 18:02:36 CRANKSHAFT-NG service_lightsensor.py[4466]: Lux = 4.3 | Level 1 -> trigger night
Nov 23 18:02:36 CRANKSHAFT-NG service_lightsensor.py[4466]: /usr/local/bin/crankshaft: line 691: [: b30: integer expression expected
Nov 23 18:02:36 CRANKSHAFT-NG service_lightsensor.py[4466]: /usr/local/bin/crankshaft: line 697: [: b30: integer expression expected
Nov 23 18:02:36 CRANKSHAFT-NG root[4507]: CSMT-LOGGER: --------------------------------------------------------------------
Nov 23 18:02:36 CRANKSHAFT-NG root[4508]: CSMT-LOGGER: Brightness Level Set To: b30
Nov 23 18:02:36 CRANKSHAFT-NG root[4509]: CSMT-LOGGER: --------------------------------------------------------------------

• Occasional issue with communicating with TSL2561 at all.

# Relevant lines from journalctl -u lightsensor.service -b
Nov 23 17:35:24 CRANKSHAFT-NG service_lightsensor.py[1542]: TSL2561
Nov 23 17:35:24 CRANKSHAFT-NG service_lightsensor.py[1542]: Traceback (most recent call last):
Nov 23 17:35:24 CRANKSHAFT-NG service_lightsensor.py[1542]:   File "/opt/crankshaft/service_lightsensor.py", line 101, in <module>
Nov 23 17:35:24 CRANKSHAFT-NG service_lightsensor.py[1542]:     Luxrounded = get_LUX(LIGHTSENSOR)
Nov 23 17:35:24 CRANKSHAFT-NG service_lightsensor.py[1542]:   File "/opt/crankshaft/service_lightsensor.py", line 34, in get_LUX
Nov 23 17:35:24 CRANKSHAFT-NG service_lightsensor.py[1542]:     Lux = get_LUX_TSL2561(TSL_I2C_BUS, TSL_ADDR)
Nov 23 17:35:24 CRANKSHAFT-NG service_lightsensor.py[1542]:   File "/opt/crankshaft/service_lightsensor.py", line 46, in get_LUX_TSL2561
Nov 23 17:35:24 CRANKSHAFT-NG service_lightsensor.py[1542]:     i2cBus.write_byte_data(TSL_ADDR, 0x80, 0x03)
Nov 23 17:35:24 CRANKSHAFT-NG service_lightsensor.py[1542]: OSError: [Errno 121] Remote I/O error

Debug Info

debug.zip

[techdev5521]

This bug is both to report the issue as well as to document the work I am doing to address it.

[Novocaine85]

I would like to add that the automatic brightness is not working at all with the sensor. On previous release (I don't remember which one, but it was a very old one like 2019) was working good.

P.s.: As the author of this issue mentioned, randomly on startup the light sensor is not detected (the lux is not even display on the main screen.) The only way to make it work again is to re-pair up crankshaft with my mobile with WiFi (using client mode).

[matt2005]

@techdev5521 I suspect the brightness issue is due to Line 691 and Line 697 as they are erroring as per your issue report
It should be reporting as an Integer but appear to be b30 so it may need a type conversion.

I suspect it got broken when i added the TSL2591 support TSL2591 support

[techdev5521]

I agree @matt2005 -- my plan is to debug the service script by stopping the service and running the script as a standalone file to see where exactly issues are. I am confident I can resolve the issues with the TSL2561 but I do not have a TSL2591 and may need your help ensuring I don't broke that if you have one. I'll see what i can do later today.

[k0bura]

My TSL2591 isn't adjusting brightness. I have the same log errors as @techdev5521

[techdev5521]

I found the issue in the Python script that handles light sensor values but I'm currently traveling without my hardware or stable Internet. I should be back to both next week and can do some testing / post updates.

[matt2005]

@techdev5521 have you been able to fix the script?

[techdev5521]

@matt2005 Yes -- I've resolved this issue. I'll try to make a PR this weekend.

[matt2005]

@techdev5521 any update on the pr for the fix?

[techdev5521]

Yes! I’m back from Colombia finally and can get that in this week. Cheers, Justin

…

On Apr 9, 2022, at 5:12 PM, Matthew Hilton ***@***.***> wrote: @techdev5521 <https://github.com/techdev5521> any update on the pr for the fix? — Reply to this email directly, view it on GitHub <#515 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACEYZKDGCNQWJAE5QLY4OXTVEHXCZANCNFSM5IUEPFQQ>. You are receiving this because you were mentioned.

[matt2005]

Any joy with the pr?

[github-actions]

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 60 days.

[techdev5521]

Hey -- sorry for dropping off the planet. I'll make time to work on this this week and submit work. The fix is fairly simple.