Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing branch #163

Closed
wants to merge 2 commits into from
Closed

Conversation

Omnikam00007
Copy link

Pull Request

Description

This PR removes the unnecessary key_prefix from time-related features in make_datetime_numpy_dict, which was previously required for ocf_datapipes

##Fixes
#162 Removed key_prefix from time features and deleted unnecessary function.

How Has This Been Tested?

#Run pytest to ensure all tests.
#there is an issue with compatibility with Pydantic v2

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@Omnikam00007
Copy link
Author

please let me know if you want me to fix compatibility

@Sukh-P
Copy link
Member

Sukh-P commented Mar 10, 2025

@Omnikam00007 I am sorry but I think we will close this PR now as it it's duplicate of another PR here, please take a look at our contribution guidelines here https://github.com/openclimatefix which will help avoid this in the future, hopefully there are some other issues you may be interested in, thank you and apologies!

@Sukh-P Sukh-P closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants