Prevent removing payment method from processing orders and return payment method info even if deleted #10073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kewitz
reviewed
May 8, 2024
| @@ -202,7 +202,7 @@ export const GraphQLOrder = new GraphQLObjectType({ | |||
| type: GraphQLPaymentMethod, | |||
| resolve(order, _, req) { | |||
| if (order.PaymentMethodId) { | |||
| return req.loaders.PaymentMethod.byId.load(order.PaymentMethodId); | |||
| return req.loaders.PaymentMethod.byIdIncludeDeleted.load(order.PaymentMethodId); | |||
There was a problem hiding this comment.
Do we really need to expose deleted assets? What is the use case?
There was a problem hiding this comment.
When looking at past contributions / transactions. If the user removes the payment method, we still want to show info about it in the contribution list/drawers.
Comment on lines
+713
to
+720
| context.loaders.PaymentMethod.byIdIncludeDeleted = new DataLoader(keys => { | ||
| return models.PaymentMethod.findAll({ | ||
| where: { | ||
| id: keys, | ||
| }, | ||
| paranoid: false, | ||
| }).then(results => sortResultsSimple(keys, results, pm => pm.id, [])); | ||
| }); |
There was a problem hiding this comment.
Quick reminder: this is only safe because we use the primary key ID in this query.
Hypothetically, we should not implement stuff like byCollectiveIdIncludedDeleted because our custom indexes exclude deleted records.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An order paid with a delayed payment method (SEPA, ACH, etc) can be processing, we prevent the payment method to be deleted in that case.
If a payment method is deleted, its info should not be missing from the order list.