Skip to content

illustrate unnecessary pad operation #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EmilySillars wants to merge 1 commit into
base: main
Choose a base branch
from
Open

illustrate unnecessary pad operation #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions codegen/compiler/src/Quidditch/Target/PadToTilingConfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,10 +403,12 @@ void PadToTilingConfig::runOnOperation() {
std::optional<IntegerAttr> attr = getConfigIntegerAttr(
IREE::HAL::ExecutableTargetAttr::lookup(getOperation()), "compute_cores");

getOperation()->emitWarning()<< "\nvvv before padding vvv";
// Pad every linalg op to a multiple of all applied tile sizes.
for (linalg::LinalgOp &linalgOp : workList)
if (failed(padToTileSize(linalgOp, attr)))
return signalPassFailure();
getOperation()->emitWarning()<< "\nvvv after padding vvv";

// First perform just the conversion of zero-pads to undef-pads.
// These must run separately from later patterns that may erase pad ops
Expand Down