Skip to content
This repository was archived by the owner on Jul 18, 2023. It is now read-only.

Update README.md #68

Merged
merged 9 commits into from
Jul 17, 2023
Merged

Update README.md #68

merged 9 commits into from
Jul 17, 2023

Conversation

mikebrow
Copy link
Member

make a bold notice regarding where people should go for guidance

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
make a bold notice regarding where people should go for guidance

Signed-off-by: Mike Brown <[email protected]>
mikebrow added 2 commits July 13, 2023 13:34

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Mike Brown <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Mike Brown <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
add changes to project status at bottom of readme.. 

Signed-off-by: Mike Brown <[email protected]>
Copy link
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the README is still misleading because it is so long. Can we create a file called README_ARCHIVED.md to maintain all this stuff, then do something like i suggest here? opencontainers/tob#126 (comment)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Mike Brown <[email protected]>
@mikebrow
Copy link
Member Author

mikebrow commented Jul 13, 2023

IMO the README is still misleading because it is so long. Can we create a file called README_ARCHIVED.md to maintain all this stuff, then do something like i suggest here? opencontainers/tob#126 (comment)

Appreciate the perspective.. Let's treat this (modifying this repo's readme with a quick succession of prs) as a work in progress moving in that ^ direction, cutting out the parts that don't need to be here (should not be here) as those parts show up in the 1.1 specs and probably including a few more tabs (here) than you have suggested just to preserve external links for redirection to the new suggested spec doc sub tabs in said artifact author guidance as it gets merged in. No reason to merge pointing to links that are not there yet :-)

side note.. archive is in the commit tree github never forgets :-)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Mike Brown <[email protected]>
Copy link
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PR #70 for some additional wording.
Note: this also depends on opencontainers/image-spec#1095 for the artifacts-guidance.md link

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: stevelasker <[email protected]>
@mikebrow mikebrow closed this Jul 17, 2023
@mikebrow mikebrow reopened this Jul 17, 2023
@mikebrow mikebrow dismissed SteveLasker’s stale review July 17, 2023 13:58

merged requested changes...

@mikebrow mikebrow merged commit a8d0d49 into main Jul 17, 2023
@mikebrow mikebrow deleted the mikebrow-patch-1 branch July 17, 2023 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants