Skip to content

Switch to Go 1.24 as a min version, bump CI, modernize sources #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Switch to Go 1.24 as a min version, bump CI, modernize sources #4851

wants to merge 4 commits into from

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Aug 14, 2025 •
edited
Loading

See individual commits for details. High level overview:

  • libct/sys/rlimit_linux: drop unused go:build tag
  • require go 1.24, add go 1.25 to CI, drop go 1.23
  • types/events: use omitzero where appropriate
  • modernize code for Go 1.24

Similar cgroups PR: opencontainers/cgroups#28

@kolyshkin kolyshkin marked this pull request as ready for review August 14, 2025 03:45
@kolyshkin

This comment was marked as duplicate.

Sign in to view
@kolyshkin kolyshkin closed this Aug 14, 2025
@kolyshkin kolyshkin reopened this Aug 14, 2025
@kolyshkin kolyshkin mentioned this pull request Aug 14, 2025
Draft
AkihiroSuda
AkihiroSuda approved these changes Aug 17, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase

@kolyshkin
libct/sys/rlimit_linux: drop go:build tag
aab4ed7 
This is not needed since commit 16d7336 which sets 1.23 to be a
minimally required Go version.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Add go 1.25, require go 1.24
bebf906 
Now that Go 1.25 is out, let's switch to go 1.24.0 as a minimally
supported version, drop Go 1.23 and add Go 1.25 to CI matrix.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
types/events: use omitzero where appropriate
62a98f2 
In these cases, omitempty doesn't really work so it is useless,
but omitzero actually works.

As a result, output of `runc events` may omit these fields if all they
contain are zeroes.

NOTE this might be a breaking change.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Modernize code for Go 1.24
f44edfa 
Brought to you by

	modernize -fix -test ./...

Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
kolyshkin commented Aug 17, 2025
View reviewed changes
Copy link
Contributor Author

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased

@rata rata enabled auto-merge August 18, 2025 12:47
rata
rata reviewed Aug 18, 2025
View reviewed changes
Copy link
Member

@rata rata left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly LGTM, left a question about the possible breaking change.

I didn't know of modernize, very nice :)

rata
rata approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rata
Copy link
Member

rata commented Aug 19, 2025

@kolyshkin there are conflicts, but after that auto-merge I guess should work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rata rata rata approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kolyshkin @rata @AkihiroSuda