[1.5] deps: bump to go-criu v8.3.0, drop google protobuf#5326
Merged
Conversation
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 2694051) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
thaJeztah
changed the title
Member
|
Missing some other bump, or is it due to Go version? |
go-criu v8.3.0 switches to protobuf-go-lite, which helps to remove google.golang.org/protobuf dependency from here, reducing the runc binary size from ~16M to ~14M. The only missing piece is proto.String, proto.Bool, proto.Int32 etc. helpers that return a pointer to a given variable. Those are replaced by a generic mkPtr, which in turn is to be replaced by the new builtin once Go < 1.26 is no longer supported. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit f66ace4) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
This PR (unlike the one in main branch) bumps x/sys/unix and I forgot to git add (a single file). Should be fixed now. |
thaJeztah
approved these changes
Jun 18, 2026
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM (assuming CI is happy)
AkihiroSuda
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #5312 and #5313 to release-1.5.
go-criu v8.3.0 partially switches to protobuf-go-lite 1, which helps
to remove google.golang.org/protobuf dependency from here,
reducing the runc binary size from ~16M to ~14M.
The only missing piece is proto.String, proto.Bool, proto.Int32 etc.
helpers that return a pointer to a given variable. Those are replaced
by a generic mkPtr, which in turn is to be replaced by the new builtin
once Go < 1.26 is no longer supported.