-
Notifications
You must be signed in to change notification settings - Fork 160
Add time namespace / TimeOffsets check and helper #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@tianon @kolyshkin @cyphar ping as you are the last 3 to have merged code here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires timeOffsets support to really be usable. time namespaces without an offset aren't really any different to just using the host timens.
|
@cyphar added a check and an helper, is this what you were thinking ? |
Signed-off-by: Etienne Champetier <[email protected]>
|
Ping @cyphar |
|
@cyphar can you review again ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Do I need to do anything to get this merged ? (rebase so CI pass or ...) |
Fixes #783