Skip to content

Conversation

@champtar
Copy link

Fixes #783

@champtar champtar requested a review from a team as a code owner January 23, 2025 03:38
@champtar
Copy link
Author

champtar commented Feb 3, 2025

@tianon @kolyshkin @cyphar ping as you are the last 3 to have merged code here

kolyshkin
kolyshkin previously approved these changes Mar 1, 2025
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin added this to the v0.10.0 milestone Mar 1, 2025
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires timeOffsets support to really be usable. time namespaces without an offset aren't really any different to just using the host timens.

@champtar
Copy link
Author

@cyphar added a check and an helper, is this what you were thinking ?
If not can you point at exactly what I should add ?

@champtar champtar changed the title Add time namespace Add time namespace / TimeOffsets check and helper May 23, 2025
@champtar
Copy link
Author

champtar commented Jun 2, 2025

Ping @cyphar

@champtar
Copy link
Author

@cyphar can you review again ?

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@champtar
Copy link
Author

champtar commented Oct 3, 2025

Do I need to do anything to get this merged ? (rebase so CI pass or ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

time namespace missing

3 participants