-
Notifications
You must be signed in to change notification settings - Fork 13
[feat] Network Costs Test #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Just wanted to drop a quick note about network costing. When we calculate network costs, we do not use the NetworkTransferBytes or NetworkReceiveBytes -- It's not a bad test to run for comparison, but as it relates to cost, we do not use these statistics for costs because they include all sub-categories of traffic (ie: local traffic, which is free). I'm not sure if the network-costs pods are installed on this cluster, so we should definitely ensure that gets done as soon as possible. |
The actual costs and usage data we use is here: https://github.com/opencost/opencost/blob/ef740759c88732487bffa644509480b070ca77c5/modules/prometheus-source/pkg/prom/metricsquerier.go#L907-L1021 But note that this requires a |
networkCostsPod.AllocNetworkInternetGiB = allocationResponseItem.NetworkInternetCost | ||
} | ||
|
||
noNegligibleCosts := false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validCostsSeen := false
@ameijer , if network zone and region tests look good, I'll go ahead anc comment those out in test.bats |
@Manas23601 looks like the tests for zone and region are failing? for those, it is ok if we don't see any valid values |
// AllocNetworkInternetGiB: 0.0, | ||
// } | ||
// continue | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this commented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted the option to drill down to a pod level if needed. do you think we need to go down further down?
Signed-off-by: Manas Sivakumar <[email protected]>
|
These are meant to fail because there is no valid zone and region costs. We should either not fail the tests if there are no valid costs or not run this test at all |
Signed-off-by: Manas Sivakumar <[email protected]>
…ion-tests into networkcost
Description
Network Costs
Prometheus Query
Testing
Network Costs
Network Internet Costs