pkg/upgrade: remove watson-studio dashboard application

Jira: https://issues.redhat.com/browse/RHOAIENG-4764

Remove deprecated dashboard resources.
Reuse existing infra just make the array of resources in a separate
function to avoid growing of CleanupExistingResource(). Because of
that moved pathName to a file scope to reuse.

Signed-off-by: Yauheni Kaliuta <[email protected]>

pkg/upgrade/upgrade.go

@@ -60,6 +60,10 @@ var (
 	gvkServiceAccount     = schema.GroupVersionKind{Group: "", Version: "v1", Kind: "ServiceAccount"}
 	gvkServiceMonitor     = schema.GroupVersionKind{Group: "monitoring.coreos.com", Version: "v1", Kind: "ServiceMonitor"}
 	gvkOdhApplication     = schema.GroupVersionKind{Group: "dashboard.opendatahub.io", Version: "v1", Kind: "OdhApplication"}
+	gvkOdhQuickStart      = schema.GroupVersionKind{Group: "console.openshift.io", Version: "v1", Kind: "OdhQuickStart"}
+	gvkOdhDocument        = schema.GroupVersionKind{Group: "dashboard.opendatahub.io", Version: "v1", Kind: "OdhDocument"}
+
+	pathName = []string{"metadata", "name"}
 )
 
 // CreateDefaultDSC creates a default instance of DSC.
@@ -273,11 +277,36 @@ func UpdateFromLegacyVersion(cli client.Client, platform deploy.Platform, appNS
 	return nil
 }
 
+func jobGetDashboardWatsonResources(ns string) []JobSpec {
+	pathAppName := []string{"spec", "appName"}
+	appName := []string{"watson-studio"}
+
+	return []JobSpec{
+		{
+			Gvk:       gvkOdhQuickStart,
+			Namespace: ns,
+			Path:      pathAppName,
+			Values:    appName,
+		},
+		{
+			Gvk:       gvkOdhDocument,
+			Namespace: ns,
+			Path:      pathAppName,
+			Values:    appName,
+		},
+		{
+			Gvk:       gvkOdhApplication,
+			Namespace: ns,
+			Path:      pathName,
+			Values:    appName,
+		},
+	}
+}
+
 // TODO: remove function once we have a generic solution across all components.
 func CleanupExistingResource(ctx context.Context, cli client.Client, platform deploy.Platform, dscApplicationsNamespace, dscMonitoringNamespace string) error {
 	var multiErr *multierror.Error
 	var toDelete []JobSpec
-	pathName := []string{"metadata", "name"}
 	// Special Handling of cleanup of deprecated model monitoring stack
 	if platform == deploy.ManagedRhods {
 		del := []JobSpec{
@@ -348,6 +377,7 @@ func CleanupExistingResource(ctx context.Context, cli client.Client, platform de
 	}
 
 	toDelete = append(toDelete, del)
+	toDelete = append(toDelete, jobGetDashboardWatsonResources(dscApplicationsNamespace)...)
 
 	multiErr = multierror.Append(multiErr, deleteResources(ctx, cli, &toDelete))