Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: message set in NewStopError/NewStopErrorW not show in pod log #1619

Closed
wants to merge 1 commit into from
Closed

update: message set in NewStopError/NewStopErrorW not show in pod log #1619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/controller/reconciler/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ func (r *Reconciler) delete(ctx context.Context, res common.PlatformObject) erro
l.Error(err, "Failed to execute finalizer", "action", action)
return err
}

l.Error(err, err.Error())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is now shown as an error intentionally because it more a flag to stop the loop, not an actual error so the action is responsible to set a proper condition. Like the absence of a per-requisite is not a reconciliation error, but a condition not met.

things are going to be improved here #1605

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will have this closed

l.V(3).Info("detected stop marker", "action", action)
break
}
Expand Down