-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom condition type for components and services #1665
Use custom condition type for components and services #1665
Conversation
52a3d24
to
b4d210f
Compare
/test all |
type ConditionSeverity string | ||
|
||
const ( | ||
ConditionSeverityError ConditionSeverity = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also seems below 2 const are not in use? excep default "" point to error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are going to be in use in a future PR
ConfiguredReason string = "Configured" | ||
RemovedReason string = "Removed" | ||
CapabilityFailed string = "CapabilityFailed" | ||
ArgoWorkflowExist string = "ArgoWorkflowExist" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not look like still in use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are going to be in use in a future PR
ConditionTypeProvisioningSucceeded = "ProvisioningSucceeded" | ||
ConditionDeploymentsNotAvailableReason = "DeploymentsNotReady" | ||
ConditionDeploymentsAvailable = "DeploymentsAvailable" | ||
ConditionServerlessAvailable = "ServerlessAvailable" | ||
ConditionServiceMeshAvailable = "ServiceMeshAvailable" | ||
ConditionArgoWorkflowAvailable = "ArgoWorkflowAvailable" | ||
ConditionTypeComponentsReady = "ComponentsReady" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these plan for future use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are going to be in use in a future PR
@zdtsw there are some leftover constants that are part of a future PR, I can remove them if you think it would be better |
can keep it now, i do not mind |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
6021d1c
into
opendatahub-io:main
Description
Extracted from #1605
How Has This Been Tested?
Screenshot or short clip
Merge criteria
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).The developer has manually tested the changes and verified that the changes work