Fix updating ID for resource

[ThibaudDauce]

No description provided.

[bolinocroustibat]

LGTM, that was quickly done!
Would that make sense, in the future, to create the ID on udata server side?

[ThibaudDauce]

LGTM, that was quickly done! Would that make sense, in the future, to create the ID on udata server side?

The front-end is using the client side ID generation to send in parallel all the chunks so not sure it's possible without changing the API (for exemple having a client side UUID then a real UUID saved in the database at the end of the upload process)… https://github.com/datagouv/front-end/blob/700fa2e57f9ae347c7b59e8eb1e5dbbff659a475/utils/datasets.ts#L175-L214

[magopian]

Nice! Thanks for the investigation and resolution, good job!

[maudetes]

Thank you for the investigation and proposed solution!

I don't think the resource id field is currently set by the frontend.
The uuid header in the multipart isn't currently used to create the Resource object, it is only used to identify the chunks the file belong to.
Comparing the uuid with the resource id shows they differ in this chunk upload test case.

I think we should make sure the resource id field is entirely readonly instead.

[maudetes]

I think we'll need to deal with existing duplicated resources ID before merging & deploying?