Add new dataservices fields #3262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maudetes
reviewed
Feb 6, 2025
| @@ -13,13 +13,13 @@ class DataserviceCsvAdapter(csv.Adapter): | |||
| ("url", lambda d: d.self_web_url()), | |||
| "description", | |||
| "base_api_url", | |||
| "endpoint_description_url", | |||
| "machine_documentation_url", | |||
There was a problem hiding this comment.
It may break the HVD DAG @Pierlou
There was a problem hiding this comment.
As long as it doesn't change anymore I'm fine with it, I'll change it when this is deployed 🤝
| or dataservice.endpoint_description_url.endswith(".yaml") | ||
| or dataservice.endpoint_description_url.endswith("?format=openapi-json") | ||
| or "GetCapabilities" in dataservice.endpoint_description_url | ||
| or "GetResourceDescription" in dataservice.endpoint_description_url |
There was a problem hiding this comment.
I've list a lot of these in my local database and did a manual check of some of them.
| def migrate(db): | ||
| log.info("Processing dataservices…") | ||
|
|
||
| Dataservice.objects(is_restricted=True, has_token=True).update( |
There was a problem hiding this comment.
I don't think we cover all cases since we can have is_restricted and has_token to None.
We should make sure that Dataservice.objects(access_type__exists=True).count() == Dataservice.objects().count() right?
There was a problem hiding this comment.
Hum… We can have None in these fields?
There was a problem hiding this comment.
I did a None request here 6e7c399
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See datagouv/udata-front#655