Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chores): Add missing tools to nix-shell #352

Merged
merged 16 commits into from
Dec 16, 2024
Merged

feat(chores): Add missing tools to nix-shell #352

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
73fce9d
:technologist: Add `kubernetes-controller-tools` to nix-shell
mhkarimi1383 Dec 10, 2024
b93549a
:technologist: Add required Go version to nix shell
mhkarimi1383 Dec 11, 2024
adc1259
:technologist: Add kubernetes tools to shell.nix
mhkarimi1383 Dec 11, 2024
be9b903
:technologist: Add minikube to shell.nix
mhkarimi1383 Dec 11, 2024
686b08d
:memo: Add nix shell to developer setup docs
mhkarimi1383 Dec 11, 2024
7757f8a
:technologist: Adding more external required tools to `shell.nix`
mhkarimi1383 Dec 11, 2024
3715d1c
:coffin: Remove minikube package option
mhkarimi1383 Dec 11, 2024
f6ebd59
:technologist: Add make to nix shell
mhkarimi1383 Dec 11, 2024
e96886f
:bug: `make` nix package name
mhkarimi1383 Dec 11, 2024
b949d82
:technologist: Add `.envrc` to automatically load nix-shell
mhkarimi1383 Dec 11, 2024
3590004
:sparkles: Isolating tmpdir and gopath in nix-shell
mhkarimi1383 Dec 12, 2024
e334875
:pencil2: Shell command order
mhkarimi1383 Dec 12, 2024
16119f4
:pencil2: Set GOCACHE
mhkarimi1383 Dec 12, 2024
d831bb6
:pencil2: Use `make bootstrap` instead of `go install`
mhkarimi1383 Dec 14, 2024
c1ce644
:see_no_evil: Add coverage file to gitignore
mhkarimi1383 Dec 14, 2024
0313fa2
:green_heart: Fix HOME env var on lint action
mhkarimi1383 Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .envrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
use nix
2 changes: 1 addition & 1 deletion docs/developer-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ git remote -v
```

Install the build dependencies.
* Run `make bootstrap` to install the required Go tools
* Run `make bootstrap` to install the required Go tools, Nix users can run `nix-shell`, it will bring up a shell with required tools installed

## Git Development Workflow

Expand Down
2 changes: 2 additions & 0 deletions nix/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
.go/
.tmp/
20 changes: 18 additions & 2 deletions shell.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,24 @@ in
pkgs.mkShell {
name = "scripts-shell";
buildInputs = with pkgs; [
chart-testing
ginkgo
git
go_1_19
golint
kubectl
kubernetes-helm
gnumake
minikube
semver-tool
yq-go
chart-testing
];
}
shellHook = ''
export GOPATH=$(pwd)/nix/.go
export GOCACHE=$(pwd)/nix/.go/cache
export TMPDIR=$(pwd)/nix/.tmp
export PATH=$GOPATH/bin:$PATH
mkdir -p "$TMPDIR"
tiagolobocastro marked this conversation as resolved.
Show resolved Hide resolved
go install sigs.k8s.io/controller-tools/cmd/[email protected]
'';
}
Loading