build: various makefile fixes #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tiagolobocastro
commented
Jan 21, 2025
•
tiagolobocastro
commented
After adjusting the code, the docs and Makefile were not updated. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
requested review from
sinhaashish,
Abhinandan-Purkait,
niladrih,
abhilashshetty04 and
dsharma-dc
Makefile commands can be run from another path, example: make -C $lvm clean In this case the pwd is not the correct path prefix! Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
changed the title
dsharma-dc
requested changes
Jan 22, 2025
Signed-off-by: Tiago Castro <[email protected]>
dsharma-dc
approved these changes
Jan 22, 2025
Ensure there's no deleting pod present Also force delete the old pods on uninstall Signed-off-by: Tiago Castro <[email protected]>
abhilashshetty04
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.