Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pool_iostat): adding protobuf for pool #52

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

abhilashshetty04
Copy link
Member

No description provided.

apis/io-engine/protobuf/v1/stats.proto Outdated Show resolved Hide resolved
apis/io-engine/protobuf/v1/stats.proto Outdated Show resolved Hide resolved
apis/io-engine/protobuf/v1/stats.proto Outdated Show resolved Hide resolved
apis/io-engine/protobuf/v1/common.proto Outdated Show resolved Hide resolved
apis/io-engine/protobuf/v1/common.proto Outdated Show resolved Hide resolved
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to wait until we branch off the release branch later this week?

apis/io-engine/protobuf/v1/common.proto Outdated Show resolved Hide resolved
apis/io-engine/protobuf/v1/stats.proto Outdated Show resolved Hide resolved
@abhilashshetty04 abhilashshetty04 force-pushed the pool_iostat_proto branch 4 times, most recently from 2b9513b to 726aa1a Compare December 7, 2023 08:58
@openebs openebs deleted a comment from bors-openebs-mayastor bot Dec 7, 2023
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this again I'm struggling with "interval" vs "time" again, but if everyone else likes then fine.

apis/io-engine/protobuf/v1/stats.proto Show resolved Hide resolved
apis/io-engine/protobuf/v1/stats.proto Outdated Show resolved Hide resolved
@abhilashshetty04 abhilashshetty04 force-pushed the pool_iostat_proto branch 2 times, most recently from 06f72a1 to 5459937 Compare December 8, 2023 13:12
@abhilashshetty04 abhilashshetty04 force-pushed the pool_iostat_proto branch 4 times, most recently from 67fe9cf to 9126cfc Compare December 8, 2023 14:00
@tiagolobocastro tiagolobocastro merged commit 049e29b into develop Dec 8, 2023
3 checks passed
@tiagolobocastro tiagolobocastro deleted the pool_iostat_proto branch December 8, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants