chore: update email content upon publish #4659

skumargupta83 · 2025-08-07T04:51:51Z

https://2u-internal.atlassian.net/browse/PROD-4410
This PR ensures that upon publishing a course run, an updated email notification is automatically sent to course editors and project coordinators.

New Email Format:
Hi Course Team,

The About Page for the [Term] course run of [Course Name] has been submitted for publishing. The new session will appear on the edX website following the next couple of deployments—typically within 24 to 48 business hours.

Note: This is a no-reply email. For any questions or comments, please contact your Project Coordinator at [PC email]

Testing:-

Create a course run
Set the course status to “Published”
Automatically receive an email from project coordinators and course editors

openedx-webhooks · 2025-08-07T04:51:55Z

Thanks for the pull request, @skumargupta83!

This repository is currently maintained by @openedx/2u-phoenix.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

DawoudSheraz · 2025-08-08T05:55:41Z

CODEOWNERS

@@ -1 +0,0 @@
-# The following users are the owners of all course-discovery files


Not sure why this file is showing up. This was deleted in a separate PR #4654. You might want to rebase your PR to get the branch up-to-date.

DawoudSheraz · 2025-08-08T05:57:52Z

course_discovery/apps/course_metadata/templates/course_metadata/email/go_live.html

    {% filter force_escape %}
        {% blocktrans trimmed %}
-            The About page for the {{ course_run_number }} course run of {{ course_name }} has been published. No further action is necessary.
+            The About Page for the {{ course_run_number }} course run of {{ course_name }} has been submitted for publishing. The new session will appear on the edX website following the next couple of deployments—typically within 24 to 48 business hours.


The comment from #4652 (comment) is not addressed here.

DawoudSheraz · 2025-08-08T05:58:36Z

course_discovery/apps/course_metadata/templates/course_metadata/email/go_live.txt

-    Note: This email address is unable to receive replies. For questions or comments, please contact your Project Coordinator(s):
+    Note: This is a no-reply email. For any questions or comments, please contact your Project Coordinator at
 {% endblocktrans %}{% for contact_us_email in contact_us_emails %}{% if forloop.last %}{{ contact_us_email }}{% else %}{{ contact_us_email }},{% endif %}{% endfor %}
+


nit: please remove the additional end of file line.

Done @DawoudSheraz

DawoudSheraz · 2025-08-08T05:59:08Z

course_discovery/apps/course_metadata/tests/test_emails.py

            'text_regexes': [
                '\n\nView this About page. %s\n' % self.course_run.marketing_url,
-                r'For questions or comments, please contact your Project Coordinator\(s\):[email protected]'
+                r'Note:This is a no-reply email. For any questions or comments, please contact your Project Coordinator at\(s\):[email protected]'


There should be a space after :. That might be causing the tests to fail.

Thank you @DawoudSheraz

DawoudSheraz

If this is the main PR now, please close #4652 and explain on that PR why was it closed.

mphilbrick211 · 2025-08-14T18:53:52Z

Hi @skumargupta83! Looks like your CLA check is failing. If you are contributing on behalf of 2U, please have your manager reach out to [email protected] so we can add you to our existing agreement. Thanks!

ankit-sonata · 2025-08-18T15:48:07Z

course_discovery/apps/course_metadata/templates/course_metadata/email/go_live.html

    {% filter force_escape %}
        {% blocktrans trimmed %}
-            Dear {{ recipient_name }},
+            Hi Course Team,


@skumargupta83 Why have you hardcoded this?

@ankit-sonata,
Below I am sharing the email template:
Hi Course Team,

The About Page for the [Term] course run of [Course Name] has been submitted for publishing. The new session will appear on the edX website following the next couple of deployments—typically within 24 to 48 business hours.

Note: This is a no-reply email. For any questions or comments, please contact your Project Coordinator at [PC email]

FYI: Please check the ticket details

ankit-sonata · 2025-08-18T15:49:20Z

course_discovery/apps/course_metadata/templates/course_metadata/email/go_live.html

        {% interpolate_html tmsg link_start='<a href="mailto:'|safe link_middle='">'|safe link_end='</a>'|safe contact_us_email=contact_us_email|safe %}
        {% else %}
-        {% interpolate_html tmsg link_start='<a href="mailto:'|safe link_middle='">'|safe link_end='</a>, '|safe contact_us_email=contact_us_email|safe %}
+        {% interpolate_html tmsg link_start='<a href="mailto:'|safe link_middle='">'|safe link_end='</a>'|safe contact_us_email=contact_us_email|safe %}


@skumargupta83 Why did you do this change?

Because In here getting extra "," so I had remove it.

ankit-sonata · 2025-08-18T15:50:28Z

course_discovery/apps/course_metadata/templates/course_metadata/email/go_live.txt


 {% blocktrans trimmed %}
-    Dear {{ recipient_name }},
+    Hi Course Team,


@skumargupta83 Why have you hardcoded this?

@ankit-sonata,
Please check the ticket Details

ankit-sonata · 2025-08-18T15:59:40Z

course_discovery/apps/course_metadata/tests/test_emails.py

            ],
        )

-    def test_send_email_for_reviewed(self):


@skumargupta83 Why did you remove this function?

@ankit-sonata,
Fixed it

ankit-sonata · 2025-08-20T19:09:25Z

@skumargupta83 make sure the bulid should pass.

skumargupta83 · 2025-08-21T04:59:19Z

@ankit-sonata,
Can you please help me to pass these below build

[Migrations check on mysql8 / check migrations (ubuntu-22.04, 3.12)
openedx/cla — We need a signed Contributor Agreement

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 7, 2025

openedx-webhooks added this to Contributions Aug 7, 2025

github-project-automation bot moved this to Needs Triage in Contributions Aug 7, 2025

skumargupta83 requested a review from DawoudSheraz August 7, 2025 04:53

DawoudSheraz reviewed Aug 8, 2025

View reviewed changes

skumargupta83 force-pushed the PROD-4410/email-update branch 2 times, most recently from e82b249 to f8f3e5f Compare August 12, 2025 12:04

skumargupta83 mentioned this pull request Aug 12, 2025

PROD-4410 Update email content upon publish #4652

Closed

mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Aug 14, 2025

skumargupta83 force-pushed the PROD-4410/email-update branch from f8f3e5f to a5a8b7e Compare August 18, 2025 14:41

ankit-sonata suggested changes Aug 18, 2025

View reviewed changes

skumargupta83 force-pushed the PROD-4410/email-update branch 2 times, most recently from dab82fa to 434a4c6 Compare August 19, 2025 10:06

skumargupta83 force-pushed the PROD-4410/email-update branch 7 times, most recently from 7f52b99 to 10f40db Compare August 26, 2025 07:48

chore: Update email content upon publish

7d9b9d3

skumargupta83 force-pushed the PROD-4410/email-update branch from 10f40db to 7d9b9d3 Compare August 26, 2025 07:53

Merge branch 'master' into PROD-4410/email-update

7884fad

skumargupta83 requested a review from rjv31 August 26, 2025 14:43

mphilbrick211 moved this from Needs Tests Run or CLA Signed to In Eng Review in Contributions Aug 27, 2025

ankit-sonata approved these changes Aug 28, 2025

View reviewed changes

rjv31 approved these changes Aug 29, 2025

View reviewed changes

hamza-56 approved these changes Sep 1, 2025

View reviewed changes

hamza-56 merged commit d06d7de into openedx:master Sep 1, 2025
14 checks passed

github-project-automation bot moved this from In Eng Review to Done in Contributions Sep 1, 2025

		@@ -1 +0,0 @@
		# The following users are the owners of all course-discovery files

chore: update email content upon publish #4659

chore: update email content upon publish #4659

Uh oh!

Conversation

skumargupta83 commented Aug 7, 2025

Uh oh!

openedx-webhooks commented Aug 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DawoudSheraz left a comment

Choose a reason for hiding this comment

Uh oh!

mphilbrick211 commented Aug 14, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ankit-sonata commented Aug 20, 2025

Uh oh!

skumargupta83 commented Aug 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants