Skip to content

fix: Removed depricate storage path #4701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jawad-khan wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Removed depricate storage path #4701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8dd598
fix: removed depricate storage path
jawad-khan Dec 5, 2025
c47196f
fix: Fixed test case
jawad-khan Dec 5, 2025
c8c14a7
fix: run flaky test
jawad-khan Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion course_discovery/apps/core/tests/test_prod_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ def test_production_media_storage(monkeypatch, tmp_path):
AWS_QUERYSTRING_EXPIRE: false
AWS_S3_CUSTOM_DOMAIN: cdn.org
AWS_STORAGE_BUCKET_NAME: tests
DEFAULT_FILE_STORAGE: storages.backends.s3boto3.S3Boto3Storage
MEDIA_ROOT: media
MEDIA_URL: https://cdn.org/media/
STORAGES:
Copy link
Contributor

@awais786 awais786 Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without STORAGES dict inside prod yaml we cant make these changes.

default:
BACKEND: storages.backends.s3boto3.S3Boto3Storage
""")
fake_config.write_text(fake_yaml_content)

Expand Down
9 changes: 0 additions & 9 deletions course_discovery/settings/production.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,6 @@
vars().update(config_from_yaml)

MEDIA_STORAGE_BACKEND = config_from_yaml.get("MEDIA_STORAGE_BACKEND", {})
default_backend = MEDIA_STORAGE_BACKEND.pop("DEFAULT_FILE_STORAGE", None)
static_backend = MEDIA_STORAGE_BACKEND.pop("STATICFILES_STORAGE", None)

if default_backend:
STORAGES["default"]["BACKEND"] = default_backend

if static_backend:
STORAGES["staticfiles"]["BACKEND"] = static_backend

# Unpack media storage settings.
# It's important we unpack here because of https://github.com/openedx/configuration/pull/3307
vars().update(MEDIA_STORAGE_BACKEND)
Expand Down
Loading