Repository navigation
fix: stop replacing the shell's query client site-wide - #635
Merged
arbrandes merged 1 commit intoSep 28, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #635 +/- ##
==========================================
- Coverage 98.60% 98.60% -0.01%
==========================================
Files 113 112 -1
Lines 1221 1220 -1
Branches 209 205 -4
==========================================
- Hits 1204 1203 -1
- Misses 16 17 +1
+ Partials 1 0 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
arbrandes
force-pushed
the
arbrandes/634-drop-query-client-provider
branch
2 times, most recently
from
September 28, 2026 17:52
abe6408 to
9afd3ad
Compare
App providers wrap the whole site, so gradebook's QueryClientProvider imposed its settings on every other app sharing the site. Its query options now live on gradebook's own hooks. Fixes openedx#634 Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
force-pushed
the
arbrandes/634-drop-query-client-provider
branch
from
September 28, 2026 18:01
9afd3ad to
82a58f1
Compare
jesusbalderramawgu
approved these changes
Sep 28, 2026
|
🎉 This PR is included in version 2.0.0-alpha.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
src/providers.tsxhanded frontend-base aQueryClientProvider, but app providers wrap the entire site rather than just the app's own routes, so any site installinggradebookAppran every other app's data fetching through gradebook's client and its settings. That only started to matter now that #632 lets gradebook share a site with the instructor dashboard.The provider is gone and gradebook's query options (5-minute staleTime, no refetch on focus, no retry on 4xx) now live in
src/data/queryOptions.ts, spread into the app's own query hooks. Query keys are already namespaced under['gradebook'], so sharing the shell's cache doesn't collide.Fixes #634
LLM usage notice
Built with assistance from Claude.