-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[CI][API][Docs] Added API docs freshness check #9232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[CI][API][Docs] Added API docs freshness check #9232
Conversation
|
See #9351 |
ef5231c to
1a68584
Compare
c909026 to
f2d0d63
Compare
|
@kojiromike Thanks for that fix :) |
| - | ||
| openemr_auth: { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why there's so much whitespace here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. What exactly wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@igormukhingmailcom there's a - for a list entry, then a newline and a bunch more indentation, then { for object entry, then a bunch of space, then }. IMO it should be:
- openemr_auth: {}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only issue here is that array ([]) somehow converted to object ({}) during normalization, but http://localhost:8300/swagger/ still renders well even with that issue.
New lines are not an issue - it was like that before (normalizer was introduced) as well. Just the way formatter formats things to have same level keys aligned.
See diff at https://github.com/openemr/openemr/pull/9197/files when normalization was introduced:
❌ 1 Tests Failed:
View the full list of 2 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
6590735 to
0422399
Compare
Co-Authored-By: Michael A. Smith <[email protected]>
b3693c2 to
9539534
Compare
Fixes #9223
Related: #9197
Screenshots
When
openemr-api.ymlis in sync with codebaseWhen
openemr-api.ymlis not in sync with codebase - job failShort description of what this resolves:
Fails when docs not refreshed after code changes.
Does your code include anything generated by an AI Engine? No