Skip to content

Conversation

@igormukhingmailcom
Copy link
Contributor

@igormukhingmailcom igormukhingmailcom commented Oct 23, 2025

Fixes #9223
Related: #9197

Screenshots

When openemr-api.yml is in sync with codebase

image

When openemr-api.yml is not in sync with codebase - job fail

image

Short description of what this resolves:

Fails when docs not refreshed after code changes.

Does your code include anything generated by an AI Engine? No

@igormukhingmailcom igormukhingmailcom marked this pull request as draft October 23, 2025 18:13
@igormukhingmailcom igormukhingmailcom mentioned this pull request Oct 23, 2025
32 tasks
@kojiromike
Copy link
Contributor

See #9351

@igormukhingmailcom igormukhingmailcom force-pushed the 9223-ci-api-docs-freshness-check branch from ef5231c to 1a68584 Compare November 5, 2025 21:31
@igormukhingmailcom igormukhingmailcom force-pushed the 9223-ci-api-docs-freshness-check branch from c909026 to f2d0d63 Compare November 5, 2025 21:55
@igormukhingmailcom igormukhingmailcom marked this pull request as ready for review November 5, 2025 21:55
@igormukhingmailcom
Copy link
Contributor Author

@kojiromike Thanks for that fix :)
Now this PR is ready for merging

Comment on lines +6184 to +6185
-
openemr_auth: { }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why there's so much whitespace here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. What exactly wrong?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igormukhingmailcom there's a - for a list entry, then a newline and a bunch more indentation, then { for object entry, then a bunch of space, then }. IMO it should be:

          - openemr_auth: {}

Copy link
Contributor Author

@igormukhingmailcom igormukhingmailcom Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue here is that array ([]) somehow converted to object ({}) during normalization, but http://localhost:8300/swagger/ still renders well even with that issue.

New lines are not an issue - it was like that before (normalizer was introduced) as well. Just the way formatter formats things to have same level keys aligned.

See diff at https://github.com/openemr/openemr/pull/9197/files when normalization was introduced:

image

@codecov
Copy link

codecov bot commented Nov 7, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1393 1 1392 49
View the full list of 2 ❄️ flaky test(s)
OpenEMR.Tests.Unit.Common.Crypto.CryptoGenTest::testCustomPasswordHmacFailure

Flake rate in main: 14.29% (Passed 6 times, Failed 1 times)

Stack Traces | 0.364s run time
OpenEMR\Tests\Unit\Common\Crypto\CryptoGenTest::testCustomPasswordHmacFailure
Failed asserting that 'test data' is false.

.../Common/Crypto/CryptoGenTest.php:565
OpenEMR.Tests.Unit.Common.Crypto.CryptoGenTest::testHmacValidationFailure

Flake rate in main: 50.00% (Passed 1 times, Failed 1 times)

Stack Traces | 0.00193s run time
OpenEMR\Tests\Unit\Common\Crypto\CryptoGenTest::testHmacValidationFailure
Failed asserting that 'test data' is false.

.../Common/Crypto/CryptoGenTest.php:545

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@igormukhingmailcom igormukhingmailcom force-pushed the 9223-ci-api-docs-freshness-check branch 4 times, most recently from 6590735 to 0422399 Compare November 7, 2025 13:39
Co-Authored-By: Michael A. Smith <[email protected]>
@igormukhingmailcom igormukhingmailcom force-pushed the 9223-ci-api-docs-freshness-check branch 3 times, most recently from b3693c2 to 9539534 Compare November 7, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API][Docs][CI] Check docs freshness by CI for PRs

2 participants