Skip to content

chore(deps): update dependency @types/lodash to v4.14.172#3259

Merged
edalex-ian merged 1 commit intodevelopfrom
renovate/definitelytyped
Aug 5, 2021
Merged

chore(deps): update dependency @types/lodash to v4.14.172#3259
edalex-ian merged 1 commit intodevelopfrom
renovate/definitelytyped

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Aug 4, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/lodash 4.14.171 -> 4.14.172 age adoption passing confidence

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled due to failing status checks.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate
Copy link
Copy Markdown
Contributor Author

renovate bot commented Aug 4, 2021

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you check the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: react-front-end/package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: storybook-react-router@1.0.8
npm ERR! Found: @storybook/addon-actions@6.3.6
npm ERR! node_modules/@storybook/addon-actions
npm ERR!   @storybook/addon-actions@"6.3.6" from @storybook/addon-essentials@6.3.6
npm ERR!   node_modules/@storybook/addon-essentials
npm ERR!     dev @storybook/addon-essentials@"6.3.6" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @storybook/addon-actions@"^4.0.0||^5.0.0||5.2.0-beta.13" from storybook-react-router@1.0.8
npm ERR! node_modules/storybook-react-router
npm ERR!   dev storybook-react-router@"1.0.8" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @storybook/addon-actions@5.3.21
npm ERR! node_modules/@storybook/addon-actions
npm ERR!   peer @storybook/addon-actions@"^4.0.0||^5.0.0||5.2.0-beta.13" from storybook-react-router@1.0.8
npm ERR!   node_modules/storybook-react-router
npm ERR!     dev storybook-react-router@"1.0.8" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /tmp/renovate-cache/others/npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate-cache/others/npm/_logs/2021-08-04T23_37_02_693Z-debug.log

@edalex-ian
Copy link
Copy Markdown
Member

Hey @ChristianMurphy , have you seen these weird renovate issues (#3259 (comment)) with storybook on any of your other projects?

It all builds fine elsewhere - as you can see in our storybook GHA job - so it's very odd. 🤔

@renovate renovate bot force-pushed the renovate/definitelytyped branch from 18f9b82 to e16e289 Compare August 4, 2021 23:38
@ChristianMurphy
Copy link
Copy Markdown
Member

ChristianMurphy commented Aug 4, 2021

I have seen it before, uPortal-webcomponents had these for a while uPortal-Project/uPortal-web-components#708 (minimized comment)
The issue is renovate supports npm 6 with lockfile version 1 and npm 7 with lockfile version 2, the two handle peerDependencies different.
npm 7 and lockfile 2 makes peer dependencies more strict and automatically installed https://github.blog/2021-02-02-npm-7-is-now-generally-available/#peer-dependencies.
oEQ is currently setup with npm 6, and the not-auto-installed more free form peer dependencies.
renovate is trying to use npm 7.

Two potential paths forward:

  1. pin npm in engines to tell both developers and renovate to use node 14 and npm 6 for now https://github.com/uPortal-Project/uPortal-web-components/blob/f63918c1c2ec134d32a970354f8157db914c400d/package.json#L140-L143
  2. Upgrade oEQ to use node 16 and npm 7

It's likely easier to start with 1, and move to 2 when there's time to circle back.

@ChristianMurphy
Copy link
Copy Markdown
Member

wait, sorry oEQ is already on 16.
Still peerDependency related, it may require some tinkering with the storybook dependencies, I'll pull latest down and take a look

@edalex-ian
Copy link
Copy Markdown
Member

Cool, thanks @ChristianMurphy , great to see it's not just some oddity here. Your two suggestions are interesting too, as both have basically been done.

First, I upgraded oEQ a few weeks back to Node 16/NPM 7 and updated the lockfiles (see #3208), and it was following this I started seeing lots of odd errors like this one pop up. So then this week I also tried to pin the engine for NPM as seen in #3254 .

So have I misread your suggestions?

(Oh! I see you've another idea and looking into it, thank you! 🙇 )

@ChristianMurphy
Copy link
Copy Markdown
Member

opened #3262 with a potential solution

@edalex-ian edalex-ian merged commit 0e1ab05 into develop Aug 5, 2021
@edalex-ian edalex-ian deleted the renovate/definitelytyped branch August 5, 2021 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants