ISAICP-6548: Preserve link attributes in menus #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The links were constructed from scratch, preserving only 'class' and 'target' attributes, and disregarding any other attributes that might be present, such as 'title', 'hreflang', aria attributes, and Drupal 'data-' attributes which are needed for JavaScript behaviors.
pfrenssen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the theme in Joinup we are seeing test failures in the navigation menus.
After investigation it appears that the menu links are rendered by creating the
<a>tag from scratch, preserving only theclassandtargetattributes. All other attributes that might be present on the link are ignored. We are missing things such as thetitleattribute, aria attributes, and Drupaldata-attributes which are needed for JavaScript behaviours.A good solution would be to use the
link()Twig function which preserves all attributes.