-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERATRANS-583: Facet checkbox widget. #172
Open
julien-
wants to merge
8
commits into
openeuropa:master
Choose a base branch
from
julien-:facets_widget_checkbox
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-
force-pushed
the
facets_widget_checkbox
branch
3 times, most recently
from
August 22, 2023 09:41
e232640
to
db3628c
Compare
julien-
commented
Aug 22, 2023
@@ -577,6 +577,7 @@ protected function getBundleOptions(string $selected_entity_type): array { | |||
$event->setListSource($this->configuration->getListSource()); | |||
} | |||
$this->eventDispatcher->dispatch($event, ListPageEvents::ALTER_BUNDLES); | |||
asort($bundle_options); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To have the Content types ordered by Label, not by machine name.
julien-
commented
Aug 22, 2023
@@ -53,7 +53,7 @@ public function getDefaultValuesLabel(): string { | |||
return ''; | |||
} | |||
|
|||
$filter_value = parent::getDefaultValues(); | |||
$filter_value = array_filter(parent::getDefaultValues()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No empty values
julien-
force-pushed
the
facets_widget_checkbox
branch
from
August 31, 2023 17:50
db3628c
to
d6b56d1
Compare
julien-
force-pushed
the
facets_widget_checkbox
branch
from
September 6, 2023 12:53
0a06618
to
5862aa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkbox widget implementation (no styles).
Added
I could use the patch :
but we need behavior of our custom ListPagesWidgetBase ... and there is no ListPagesWidgetTrait existing so let see if we need Trait in the future to extends contrib widgets.
Changed
Sort alphabetically in back-office the Bundles by their labels
Description
Usage viewable here : https://www.era.europa.eu/agency-you/selection-procedures/vacancies