Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERATRANS-583: Facet checkbox widget. #172

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

julien-
Copy link

@julien- julien- commented Mar 1, 2023

Checkbox widget implementation (no styles).

Added

  • Checkbox widget (based on existing MultiselectWidget custom widget)
    I could use the patch :
"drupal/facets" : {
  "#2937191 Render using theme input and select instead of lists with links for checkboxes and dropdown" : "https://www.drupal.org/files/issues/2023-08-11/facets-2937191-76-2.x.diff"
}

but we need behavior of our custom ListPagesWidgetBase ... and there is no ListPagesWidgetTrait existing so let see if we need Trait in the future to extends contrib widgets.

Changed

Sort alphabetically in back-office the Bundles by their labels

Description

Usage viewable here : https://www.era.europa.eu/agency-you/selection-procedures/vacancies

@julien- julien- closed this Aug 16, 2023
@julien- julien- reopened this Aug 16, 2023
@julien- julien- force-pushed the facets_widget_checkbox branch 3 times, most recently from e232640 to db3628c Compare August 22, 2023 09:41
@@ -577,6 +577,7 @@ protected function getBundleOptions(string $selected_entity_type): array {
$event->setListSource($this->configuration->getListSource());
}
$this->eventDispatcher->dispatch($event, ListPageEvents::ALTER_BUNDLES);
asort($bundle_options);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To have the Content types ordered by Label, not by machine name.

@@ -53,7 +53,7 @@ public function getDefaultValuesLabel(): string {
return '';
}

$filter_value = parent::getDefaultValues();
$filter_value = array_filter(parent::getDefaultValues());
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No empty values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant