ISAICP-6036: Initial split off from the main project. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the base branch.
…the deprecated ones.
claudiu-cristea
requested changes
Mar 15, 2021
| * | ||
| * @return \Robo\Collection\CollectionBuilder | ||
| */ | ||
| public function settingsSetup(array $options = [ |
There was a problem hiding this comment.
We don't need this here. It should be in the other repo. See openeuropa/task-runner#150 review.
Comment on lines
+440
to
+447
| public function permissionsSetup(array $options = [ | ||
| 'root' => InputOption::VALUE_REQUIRED, | ||
| 'sites-subdir' => InputOption::VALUE_REQUIRED, | ||
| ]) | ||
| { | ||
| trigger_error("The 'drupal:permissions-setup' command is deprecated in openeuropa/task-runner:1.0.0 and will be removed * in openeuropa/task-runner:2.0.0. Use the 'drupal:setup-permissions' command instead.", E_USER_DEPRECATED); | ||
| return $this->setupPermissions($options); | ||
| } |
There was a problem hiding this comment.
Why do we deprecate this? It was supposed only to be moved.
There was a problem hiding this comment.
The way you wrote it in the issue description, we want to change the drupal:permissions-setup to drupal:setup-permissions without breaking BC. The way I thought of this is that both commands will work at the same time since other projects might still be using the drupal:permissions-setup. Thus, I kept the original method but I am throwing a deprecation message that the command is to be replaced by the drupal:setup-permissions and calling that method instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.