External commands should be registered before custom commands

[claudiu-cristea]

Problem

Right now, the dynamic/custom commands are registered in the TaskRunner constructor. The external commands, provided by 3rd party, are registered after TaskRunner has been constructed, in ./bin/run:

$runner = new TaskRunner();
$runner->registerExternalCommands($classLoader);

For this reason a custom command cannot add an external command as a task because at that moment the external command is not yet registered.

Solution

Call ::registerExternalCommands() from the TaskRunner constructor, just before calling ::registerDynamicCommands().

[ademarco]

@claudiu-cristea we moved to the new native Robo plugin system, does this still happen on latest master?