Update status code for CRUD operations

This commit updates the status code from 200 to 202 for create, update or delete APIs. Fixes: #25 Signed-off-by: Vivek Singh <[email protected]>
openfaas · Sep 28, 2018 · 7dc0494 · 7dc0494
1 parent 1bcf4a5
commit 7dc0494
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/handlers/delete.go b/handlers/delete.go
@@ -71,7 +71,7 @@ func DeleteHandler(c *client.Client) http.HandlerFunc {
 			log.Println(serviceRemoveErrors)
 			w.WriteHeader(http.StatusInternalServerError)
 		} else {
-			w.WriteHeader(http.StatusOK)
+			w.WriteHeader(http.StatusAccepted)
 		}
 
 	}

diff --git a/handlers/deploy.go b/handlers/deploy.go
@@ -97,6 +97,8 @@ func DeployHandler(c *client.Client, maxRestarts uint64, restartDelay time.Durat
 		if len(response.Warnings) > 0 {
 			log.Println(response.Warnings)
 		}
+
+		w.WriteHeader(http.StatusAccepted)
 	}
 }
 
@@ -362,7 +364,7 @@ func buildLabels(request *requests.CreateFunctionRequest) (map[string]string, er
 	}
 
 	if request.Annotations != nil {
-		for k,v := range *request.Annotations {
+		for k, v := range *request.Annotations {
 			key := fmt.Sprintf("%s%s", annotationLabelPrefix, k)
 			if _, ok := labels[key]; !ok {
 				labels[key] = v

diff --git a/handlers/replicas_updater.go b/handlers/replicas_updater.go
@@ -58,6 +58,7 @@ func ReplicaUpdater(c *client.Client) http.HandlerFunc {
 			return
 		}
 
+		w.WriteHeader(http.StatusAccepted)
 	}
 }
 

diff --git a/handlers/update.go b/handlers/update.go
@@ -95,9 +95,12 @@ func UpdateHandler(c *client.Client, maxRestarts uint64, restartDelay time.Durat
 			w.Write([]byte("Update error: " + err.Error()))
 			return
 		}
+
 		if response.Warnings != nil {
 			log.Println(response.Warnings)
 		}
+
+		w.WriteHeader(http.StatusAccepted)
 	}
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -58,6 +58,7 @@ func ReplicaUpdater(c *client.Client) http.HandlerFunc { @@
     			return
     		}
+    		w.WriteHeader(http.StatusAccepted)
     	}
     }
@@ Expand Down @@