Make basic-auth optional

- This is a feature flag depending on the env-var "basic_auth" Signed-off-by: Alex Ellis (VMware) <[email protected]>
openfaas · Sep 10, 2018 · c2fcde9 · c2fcde9
1 parent 3795853
commit c2fcde9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/server.go b/server.go
@@ -61,7 +61,7 @@ func main() {
 		WriteTimeout:    cfg.WriteTimeout,
 		TCPPort:         &cfg.TCPPort,
 		EnableHealth:    true,
-		EnableBasicAuth: true,
+		EnableBasicAuth: cfg.EnableBasicAuth,
 		SecretMountPath: "/run/secrets",
 	}
 

diff --git a/types/read_config.go b/types/read_config.go
@@ -72,12 +72,15 @@ func (ReadConfig) Read(hasEnv HasEnv) BootstrapConfig {
 	cfg.ReadTimeout = readTimeout
 	cfg.WriteTimeout = writeTimeout
 
+	cfg.EnableBasicAuth = parseBoolValue("basic_auth", false)
+
 	return cfg
 }
 
 // BootstrapConfig for the process.
 type BootstrapConfig struct {
-	ReadTimeout  time.Duration
-	WriteTimeout time.Duration
-	TCPPort      int
+	ReadTimeout     time.Duration
+	WriteTimeout    time.Duration
+	TCPPort         int
+	EnableBasicAuth bool
 }