Adds env features from original watchdog #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Fan <[email protected]>
thomasjpfan
force-pushed
the
serializing-fork-headers
branch
from
f436f1f to
0e53c27
Compare
|
Closing this for now to adapt to openfaas's workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Fan [email protected]
Adds the additional cgi headers into the environment, mirroring the original
watchdog.Description
Adds additional environment variables in
getEnvironment.Motivation and Context
For
of-watchdogto be backwards compatibility with the originalwatchdog, the additional headers feature in CGI mode should be included.Partially addresses #25 by adding more unit tests from mode=serializing.
How Has This Been Tested?
The unit tests from the original
watchdogregarding the headers was migrated.Types of changes
Checklist:
git commit -s