Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings for multiple molecules and tests #1939

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Conversation

j-wags
Copy link
Member

@j-wags j-wags commented Sep 27, 2024

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.76%. Comparing base (747c2f1) to head (053a24e).
Report is 1 commits behind head on main.

Additional details and impacted files

@j-wags
Copy link
Member Author

j-wags commented Sep 28, 2024

Hm, CI currently indicates that this this leads to a consistent, significant slowdown that's tripping a timeout on an unrelated test. I don't want to merge with failing tests and it's possible that another approach wouldn't have this slowdown, so I'll kick CI now and come back to this Monday.

@j-wags
Copy link
Member Author

j-wags commented Sep 30, 2024

Reran twice over the weekend and it came out all green, so I'll just merge this and I can relax the timeout later if needed.

@j-wags j-wags merged commit 31e4c4b into main Sep 30, 2024
18 checks passed
@j-wags j-wags deleted the warn-on-multi-mol-mols branch September 30, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce that Molecule cannot represent multiple molecules
2 participants