Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused fixture(s) #1951

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unused fixture(s) #1951

wants to merge 1 commit into from

Conversation

mattwthompson
Copy link
Member

I found this nice plugin while debugging some unforced errors in another project. Fortunately it looks like the toolkit isn't hanging onto too much dead code in this respect

$ git checkout 0.16.5 && pytest --dead-fixtures                                                 8:30:21  ☁  0.16.5 ☀
HEAD is now at f8110b56 Fix merge (#1943)

Hey there, I believe the following fixture(s) are not being used:
Fixture name: create_circular_handler_dependencies, location: openff/toolkit/_tests/test_forcefield.py:1262
Fixture name: alkethoh_forcefield, location: openff/toolkit/_tests/test_forcefield.py:771

1 error in 8.75s

alkethoh_forcefield is actually used in a few places, it seems like

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (6aa989e) to head (c974c74).

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review October 24, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant