Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal patch for JSON deserialization of _SimpleMolecules #1958

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Minimal patch for JSON deserialization of _SimpleMolecules #1958

merged 2 commits into from
Nov 7, 2024

Conversation

mattwthompson
Copy link
Member

Resolves #1955

@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (cb6bcc4) to head (ae6889c).
Report is 4 commits behind head on main.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review November 5, 2024 18:02
j-wags
j-wags approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's silly but it works, it isn't silly.

@j-wags j-wags merged commit 9c122a2 into main Nov 7, 2024
18 checks passed
@j-wags j-wags deleted the simple-molecule-json branch November 7, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topology cannot roundtrip with JSON when composed of _SimpleMolecules
2 participants
@mattwthompson @j-wags