Export basemap as mbtiles during cable export #105
Conversation
There was a problem hiding this comment.
Thoughts and reflections about the ongoing dev work made so far.
ping @suricactus
| @@ -556,6 +558,26 @@ def _export_basemap(self) -> bool: | |||
| ) | |||
| return False | |||
|
|
|||
| exported_tiff = self._export_basemap_as_tiff(extent, base_map_type) | |||
There was a problem hiding this comment.
Should this tiff basemap generation function still be called there ?
| feedback = QgsProcessingFeedback() | ||
| context = QgsProcessingContext() | ||
| context.setProject(project) | ||
| context.setFlags(context.flags() | QgsProcessingAlgorithm.FlagNoThreading) |
There was a problem hiding this comment.
Have been adding this line to stabilize the behaviour of the export, since I faced some QGIS crashes when developing this.
Con side: makes the external processing alg run on the main thread, thus freezing QGIS during this mbtiles export, which might possibly be long in case the user has some data on a large area, and configured min/max tiles zoom level with a big interval.
This needs to be discussed IMO.
There was a problem hiding this comment.
For sure we should not be running this on the main thread. Let's discuss ways to run this in the background.
| @property | ||
| def base_map_tiles_min_zoom_level(self) -> int: | ||
| base_map_tiles_min_zoom_level, _ = self.project.readNumEntry( | ||
| "qfieldsync", ProjectProperties.BASE_MAP_TILES_MIN_ZOOM_LEVEL, 14 |
There was a problem hiding this comment.
Am wondering about mbtiles min / max zoom default values. My proposition is 14 / 16, open to discussion.
There was a problem hiding this comment.
I would better go for 14/14.
This PR makes the cable export generate a
mbtilesbasemap for QField, thus enabling multiple raster zoom levels.Subtasks:
native:tilesxyzmbtilesprocessing algorithm to generate a mbtiles fileSingle layerbasemap mbtiles export during cable exportSingle layerbasemap mbtiles export during cable exportSingle layerbasemap mbtiles in QField appMap themebasemap mbtiles export during cable exportMap themebasemap mbtiles export during cable export as well as QField usageMap themebasemap mbtiles in QField app