Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AdaptedThreadPoolDestroyPostProcessor.java add default impl #1384

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

MagikLau
Copy link
Contributor

@MagikLau MagikLau commented Jul 6, 2023

Make a default implementation of the resolved method 'abstract java.lang.Object postProcessBeforeInitialization(java.lang.Object, java.lang.String)' of interface org.springframework.beans.factory.config.BeanPostProcessor
Fix match case: spring-beans-4.3.21.RELEASE.jar
Forked from: spring-beans-5.1.14.RELEASE.jar

Fixes ISSUSE

Unable to start embedded container; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.springframework.boot.autoconfigure.web.EmbeddedServletContainerAutoConfiguration$EmbeddedTomcat': Initialization of bean failed; nested exception is java.lang.AbstractMethodError: Receiver class cn.hippo4j.springboot.starter.support.AdaptedThreadPoolDestroyPostProcessor does not define or inherit an implementation of the resolved method 'abstract java.lang.Object postProcessBeforeInitialization(java.lang.Object, java.lang.String)' of interface org.springframework.beans.factory.config.BeanPostProcessor.

Changes proposed in this pull request:

  • Compatible with lower versions of spring-beans

Check mailbox configuration when submitting. Contributor Guide

Fix match case: spring-beans-4.3.21.RELEASE.jar
Forked from: spring-beans-5.1.14.RELEASE.jar
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d4bb9e3) 35.49% compared to head (490fffd) 35.49%.

❗ Current head 490fffd differs from pull request most recent head 06570eb. Consider uploading reports for the commit 06570eb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1384   +/-   ##
==========================================
  Coverage      35.49%   35.49%           
  Complexity       843      843           
==========================================
  Files            258      258           
  Lines           5722     5722           
  Branches         530      530           
==========================================
  Hits            2031     2031           
  Misses          3498     3498           
  Partials         193      193           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@magestacks magestacks merged commit 10bc5c3 into opengoofy:develop Jul 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants