Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: hippo4j config model in nacos config before check #1438

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

2084276225
Copy link
Contributor

@2084276225 2084276225 commented Sep 1, 2023

#1439

Changes proposed in this pull request:

Check mailbox configuration when submitting. Contributor Guide

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07% ⚠️

Comparison is base (de703cf) 34.67% compared to head (5561df0) 34.61%.
Report is 7 commits behind head on develop.

❗ Current head 5561df0 differs from pull request most recent head d4f5c70. Consider uploading reports for the commit d4f5c70 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1438      +/-   ##
=============================================
- Coverage      34.67%   34.61%   -0.07%     
  Complexity       847      847              
=============================================
  Files            262      262              
  Lines           5877     5888      +11     
  Branches         540      544       +4     
=============================================
  Hits            2038     2038              
- Misses          3646     3657      +11     
  Partials         193      193              
Files Changed Coverage Δ
.../java/cn/hippo4j/common/toolkit/CalculateUtil.java 50.00% <ø> (ø)
.../hippo4j/core/enable/BeforeCheckConfiguration.java 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@magestacks magestacks merged commit 651cc90 into opengoofy:develop Sep 2, 2023
3 checks passed
@2084276225 2084276225 deleted the zcq3 branch September 2, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants