Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimization the registerDynamicThreadPool method of the DynamicThreadPoolConfigService class #1515

Closed
wants to merge 1 commit into from

Conversation

Dawanyezhi
Copy link
Contributor

Changes proposed in this pull request:
Delete the duplicate subscription operation here, as the unified subscription change operation has been performed in the postProcessAfterInitialization method of the DynamicThreadPoolPostProcessor class. Keeping this will result in the duplicate registration of callback, causing the thread pool to execute the callback repeatedly when receiving configuration changes.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (265bf6e) 34.23% compared to head (ffcf698) 34.21%.
Report is 4 commits behind head on develop.

❗ Current head ffcf698 differs from pull request most recent head 83d9578. Consider uploading reports for the commit 83d9578 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1515      +/-   ##
=============================================
- Coverage      34.23%   34.21%   -0.02%     
+ Complexity       847      846       -1     
=============================================
  Files            262      262              
  Lines           5953     5953              
  Branches         560      560              
=============================================
- Hits            2038     2037       -1     
- Misses          3722     3723       +1     
  Partials         193      193              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dawanyezhi Dawanyezhi closed this Nov 17, 2023
@Dawanyezhi Dawanyezhi deleted the dev_optfunction branch November 17, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant