fix: SPI of the ThreadPoolMonitor #1518
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onitor cannot be introduced through the SPI mechanism in the ReportingEventExecutor class when the project is started.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1518 +/- ##
=============================================
+ Coverage 34.23% 34.33% +0.10%
- Complexity 847 849 +2
=============================================
Files 262 262
Lines 5953 5953
Branches 560 560
=============================================
+ Hits 2038 2044 +6
+ Misses 3722 3717 -5
+ Partials 193 192 -1 ☔ View full report in Codecov by Sentry. |
magestacks
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Fix the problem that a custom implementation class of ThreadPoolMonitor cannot be introduced through the SPI mechanism in the ReportingEventExecutor class when the project is started.