Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix_checkInConfig #1521

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

Dawanyezhi
Copy link
Contributor

Changes proposed in this pull request:
Fix the problem that the dynamicThreadPoolBeforeCheckBean method in the BeforeCheckConfiguration class cannot validate parameters effectively in the config mode.

…in the BeforeCheckConfiguration class cannot validate parameters effectively in the config mode.
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (265bf6e) 34.23% compared to head (2d7bcac) 34.28%.
Report is 7 commits behind head on develop.

Files Patch % Lines
.../hippo4j/core/enable/BeforeCheckConfiguration.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1521      +/-   ##
=============================================
+ Coverage      34.23%   34.28%   +0.05%     
- Complexity       847      849       +2     
=============================================
  Files            262      262              
  Lines           5953     5953              
  Branches         560      561       +1     
=============================================
+ Hits            2038     2041       +3     
+ Misses          3722     3720       -2     
+ Partials         193      192       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@magestacks magestacks merged commit ccccfd8 into opengoofy:develop Nov 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants