Added initial CommonJS support#270
Closed
jpg0 wants to merge 1 commit intoopenhab-scripters:masterfrom
Closed
Conversation
Author
|
Oh, and one other thing as mentioned elsewhere: this really shows that utils.js should be broken up into logical parts. It seems to cover a little bit of everything. For example one of the first things that I'd do is move |
Author
|
After looking at this, I have discovered that there is a problem:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR as discussed in #267
This implements a CommonJS module system for loading libraries.
I do believe that pulling the loading engine up into OH code would be better, but agree that we should wait for JDK9/ES6 before we do this (although if it really drags on, I may do it). Either way, this PR means that all library code written now would be compatible with that future.