-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ephemeris] Add option for disabling the cache #4491
base: main
Are you sure you want to change the base?
Conversation
…ching. This in interesting especially when defining/debugging these files. Signed-off-by: Gaël L'hopital <[email protected]>
The caching behaviour has been identified as a source of problems many times in the forum. |
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Signed-off-by: Gaël L'hopital <[email protected]>
It would be nicer if it would monitor changes to the file instead (e.g. using the |
That was my first thought but I though this could be a first easy step. I blocked myself because ephemeris does not have a dedicated folder for user defined files, so they can be anywhere but I'll have a look at WatchService also. |
@clinique Could you please have a look at the failing tests? |
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@clinique Any idea why the tests keep failing? It seems unrelated, but it is still failing, even after retriggering. |
Adds possibility to disable user defined holiday description files caching.
This in interesting especially when defining/debugging these files.
A new option can be set in the ephemeris.cfg file,
cache=true/false
.Default value is true, so no breaking change if the option is absent.