Fixes to Notification Request examples #675
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fication Request example. Added a new Notification Request example to accompany the pre-existing “Credential was deleted by the End-User” example description.
…leted by the End-User” Notification Request example. The verb “deleted” can be understood to mean a deletion that the user does much later after accepting the issuance of the credential while “rejected” is much more tied to the issuance of the credential.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes a fix to an inconsistency in the second Notification Request example by adding a proper
credential_deletedexample and adding a new description to thecredential_failureexample. The pull request also proposes changing “was deleted by the End-User” with “was rejected by the End-User”, because the verb “deleted” can be understood to mean a deletion that the user does much later after accepting the issuance of the credential (which might not be supported, see #673), while “rejected” is much more tied to the issuance of the credential.This pull request relates to issue #674. The inconsistency in the second Notification Request is explained there.