Skip to content

Fixed the issue where multiple terminals may log in using the same token #3576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed the issue where multiple terminals may log in using the same token #3576

wants to merge 2 commits into from

Conversation

@wittenjing
Copy link

@wittenjing wittenjing commented Sep 25, 2025 •
edited
Loading

#3575 🅰 Please add the issue ID after "Fixes #"

Fixes #

When the app changes its connection from server A to server B, the memory allocated for the old connection in server A is not reclaimed.

Related bug: #3449

Scenario:

multiple terminals may log in using the same token

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025 •
edited
Loading

🤖 All Contributors have signed the CLA.
The signed information is recorded here
Posted by the CLA Assistant Lite bot.

@wittenjing
Copy link
Author

wittenjing commented Sep 26, 2025

I have read the CLA Document and I hereby sign the CLA

OpenIM-Robot added a commit to OpenIM-Robot/cla that referenced this pull request Sep 26, 2025
@OpenIM-Robot
@wittenjing has signed the CLA in openimsdk/open-im-server#3576
be7e85a
@wittenjing wittenjing changed the title fix oldClient object memory leak Fixed the issue where multiple terminals may log in using the same token Sep 29, 2025
mo3et
mo3et requested changes Sep 30, 2025
View reviewed changes
Copy link
Member

@mo3et mo3et left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, Thanks for your contribution! This fix is solve in main and 3.8.3-patch branch but not in v3.8.4.

Just need add log when oldclient token is same to newClient token is ture.

I will merge it to v3.8.4 version when this PR is merged.

@mo3et mo3et enabled auto-merge September 30, 2025 04:04
auto-merge was automatically disabled October 10, 2025 07:57

Head branch was pushed to by a user without write access

@wittenjing wittenjing requested a review from mo3et October 10, 2025 08:05
@mo3et mo3et enabled auto-merge October 10, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mo3et mo3et mo3et approved these changes

@Bloomingg Bloomingg Awaiting requested review from Bloomingg Bloomingg is a code owner

@FGadvancer FGadvancer Awaiting requested review from FGadvancer FGadvancer is a code owner

@skiffer-git skiffer-git Awaiting requested review from skiffer-git skiffer-git is a code owner

@withchao withchao Awaiting requested review from withchao withchao is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wittenjing @mo3et